I'm up for working on the new idiom now. I've put this much time into it, I don't want to waste the momentum. What's the approach you are thinking of, and how can I get started in the implementation?
On Apr 28, 4:28 pm, Carl Meyer <c...@oddbird.net> wrote: > Hi Eduardo, > > On 04/28/2011 12:35 PM, legutierr wrote: > > > I just added a new patch in response to Carl's comments on the ticket. > > >http://code.djangoproject.com/ticket/13091 > > So, in the process of reviewing and tweaking this patch for commit, I > checked in the #django-dev IRC channel for any other core dev opinionsm > since I didn't feel 100% confident that we were doing the right thing > here. I talked through the issue with Alex Gaynor, and he successfully > convinced me that we aren't. Specifically: > > 1. We have an idea in mind, as I mentioned above, for a new > modelform-validation idiom that would solve this problem fully, by > requiring tweaks to the model to happen pre-validation and then > validating the full model. > > 2. If we implement the new idiom, and convert the admin to use it, then > anyone who runs into the problems with the current partial-validation > scheme in their own code can simply switch to the new recommended idiom. > Nobody will be stuck. > > 3. The current proposed patch on #13091 only improves the current > situation very marginally; there are a lot of cases it still wouldn't > catch (anytime a field involved in a unique-together is modified > post-validation and pre-save, and the odd exclusions for default/blank > fields). It's very much an incomplete fix, and yet it introduces new > complexity both to the code and the documentation, when we already have > a better alternative fix in mind. > > So I apologize for leading you to spend time on that patch and then > switching gears. In terms of what's best for Django, I think Alex is > right on this one, so I plan to just work on the better fix rather than > committing the current patch on #13091. > > Carl -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
