On Aug 19, 1:25 am, Paul McMillan <p...@mcmillan.ws> wrote:
> I added some test cases and cleaned the code up a bit. I believe sure
> this solution is backwards compatible (we're adding the string
> conversion, something that shouldn't have been possible before), but
> I'd like input from some other people.
>
> -Paul
>
> [1]https://code.djangoproject.com/ticket/16494

I took a look of the patch. The patch is backwards compatible, but the
problem is that I don't think the current implementation is correct.
It consumes the iterator multiple times. See the comments in the
ticket for details.

 - Anssi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to