On Tue, Oct 11, 2011 at 02:06, Luke Plant <l.plant...@cantab.net> wrote:
> On 10/10/11 23:05, Carl Meyer wrote: > > > Unless there are significant objections, I'd like to commit this in the > > next few days and get it into 1.4. I'll also modify the patch on #16360 > > to take advantage of the new layout; hopefully that can get into 1.4 as > > well. > > Definitely +1, as this has bitten me far too often. It would be nice however to also depend less on the ('hacky', as Glyph also noted) DJANGO_SETTINGS_MODULE environment variable. We shouldn't need an env variable to run a python website, and it certaintly shouldn't screw up settings loading when set accidently. The new proposed setup_settings function accepts a path, but listens to the env variable first, and if that is not set it it wil still try to load 'settings'. Why not listen to the path that is provided so I can pass 'mysite.settings.production' for example? And if it's not provided, listen to DJANGO_SETTINGS_MODULE for backwards compatibility. Tino -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.