Mentioned on the PR already, but writing some thoughts here too. I like the change. Moving test settings into their own sub-dict makes a lot of sense. Missing are settings for creating the datafile and datafile size for Oracle though. I'm unsure if a separate patch should be submitted for those new settings or not. I'd really like if those new settings could be added for 1.7, to enable oracle test databases to be created by the test runner.
Currently, Oracle GIS can't be tested without first creating the test database (due to the datafile size). Similarly, the test runner can not create the database for Oracle RAC because of the datafile name. Regards, Josh On Thursday, 6 March 2014 06:41:57 UTC+11, Shai Berger wrote: > > Hi, > > I've put up https://github.com/django/django/pull/2400 for review. It > makes > the changes discussed -- test settings go into a 'TEST' dictionary in the > database settings, with a deprecation warning for old settings. > > While at it, I added (in a separate commit) a renaming of two > Oracle-specific > settings -- because I don't like current names, and this is a good > opportunity > to change them. At some future point, I want to make "CREATE_DB" available > to > all backends, so this renaming is not just an Oracle issue. > > There is documentation, but no tests -- database settings are impossible > to > test automatically. > > I want this to go in before the beta; it's a rather small PR. If there are > no > comments, I'll probably commit it tomorrow or the day after. > > Have fun, > Shai. > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/a408612c-3bd3-4302-8ceb-a5e5a96c5570%40googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
