It took 7 minutes and 23 seconds to merge this troll PR without any discussion and now Meira is suggested to wait 6 months? But what can happen?
вторник, 27 мая 2014 г., 16:14:43 UTC+4 пользователь Meira написал: > > As some of you may have notice, a hot discussion is happening in the > comments of this pull request: https://github.com/django/django/pull/2692 > Essentially, this pull request suggests that all occurences of > master/slave be replaced with leader/follower. While this is clearly > insane, a less jaw-dropping, but still weird change was made in commit > https://github.com/django/django/commit/beec05686ccc3bee8461f9a5a02c607a02352ae1 > > Many users in comments to the original pull request agreed that > primary/replica is not a good word choice, is vague and misleading. Current > django docs compensate for the confusion by referring to "master/slave" in > parentheses after mentioning "primary/replica". Of course, this change is > nothing more than cosmetical, but it still carries more downsides than > upsides. > Master/slave is* immediately obvious* for the experienced users, and *easily > googleable* for the newbies. > > I reverted the change and sent a pull request > https://github.com/django/django/pull/2720. In the corresponding ticket, > I was told to "wait 6 months" and then resubmit the ticket. ( > https://code.djangoproject.com/ticket/22707), and the pull request was > closed immediately with an advice to start a discussion on mailing list. So > that's what I'm doing here :) > > I sum up my personal point of view in this comment: > https://github.com/django/django/pull/2692#issuecomment-44265422 > > Of course, it'll be hard for the django maintainers to admit their mistake > and revert the change. It's always hard to admit mistakes, but it's better > than leaving it how it is. > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/66d7cc89-4e34-4227-ad1d-540bd90c2978%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
