+1, as_vendor() is IMO rather clean and expressive as a end user API. 3rd party backends are indeed a concern but we discussed this briefly on IRC today and I believe we have an acceptable solution for them, Josh is planning to write up about it.
-- Loic On Monday, June 30, 2014 7:08:38 PM UTC+7, Marc Tamlyn wrote: > > FWIW I agree with Anssi > > Marc > > > On 30 June 2014 12:00, Anssi Kääriäinen <anssi.ka...@thl.fi <javascript:>> > wrote: > >> On Mon, 2014-06-30 at 12:56 +0300, Josh Smeaton wrote: >> > >Still, I don't see *any* advantage of doing this compared to just >> > providing the same implementation method in the node itself with the >> > as_vendor syntax >> >> >> > >> > >> > Me neither. I think I confused the subject when I brought up putting >> > differences into the backend - but I was trying to highlight the >> > difference because it's not usually how django does things. If someone >> > has an actual concern with the `as_vendor()` can you please mention >> > it, and why. Otherwise I think we can proceed as-is with the >> > as_vendor. Do you agree Anssi? >> >> We can continue with as_vendor() no matter what the resolution is. We >> already have the exact same problem for Lookups and Transforms, so we >> aren't adding new problems by continuing with as_vendor(). >> >> Michael feels backend.ops.compile() is useful for django-mssql. Also, >> multiple core developers think the as_vendor() syntax is bad because it >> is monkey patching, or places 3rd party backends in unfair position. I >> don't agree, but I don't see other core developers supporting my >> position. >> > -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/503f2fcb-48c6-484f-8309-2c76c5c7873f%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
