All right, that's exactly what I'm talking about. You wrote more than 50 lines of python code, reimplemented standard inextensible features, just to call one function. And changing password is simple task actually, reseting password needs to deal with tokens, emails, etc. So it will be a few Much more code to write and much more things to understand. I'm not sure how Django tokens work, for instance, or how to use them correctly, so I'll probably copy-paste hoping I broke nothing. Default password_reset view has 12 parameters. Should I match signature of my custom view or not? There are a lot of questions related to reimplementing, which can be answered only by deep learning of Django sources.
And what if you have two backends? As far as I understand you'll have to dispatch this somehow in the view or form, i.e. you'll have to invent extensibility by yourself, or introduce tight coupling by mixing actions related to hardcoded list of backends. That is what I do not like in the first place. Josh, what do you think? Do you see anything I missed? Or maybe you have some different priorities? I highly interested in you opinion. Roman On Monday, December 15, 2014 1:18:07 AM UTC+4, Josh Smeaton wrote: > > Correct - I've updated the gist: > https://gist.github.com/jarshwah/c5b9abebb452f2e3286f > > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/4097ef44-60cb-47d9-bd60-96e661e3b6fb%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
