Hi Varun, I've just taken a look at this proposal; I've got some concerns.
* You say you can get test coverage from 81% to 90% - that's an admirable goal, but is there any reason to believe that it is achievable? In many cases, the coverage is low because a feature/branch is so difficult to test that the cost in developing test harnesses vastly exceeds the likelihood of breakage, or because the branches that aren't covered aren't *ever* going to be executed (i.e "you shouldn't be here" branches). Don't get me wrong - more coverage would be better - but you're going to need to provide evidence of what you're going to focus on to gain 9% in test coverage. It's not just a matter of saying "I'm gonna get 9% more". * I am in no way convinced that shuffling deck chairs to have a unit/integration/regression separation will be in any way helpful. Django once had a separate regression tests directory - we *removed* that separation specifically because it was becoming burdensome to identify whether a test was a "core function" test or a "regression" test. * I'm not convinced that more options to ./runtests.py is an area where we should be spending effort - or, to the extent that it is, we should only be seeking to expose functionality provided by the base unittest runner. If this means that changes are needed in unittest itself, then that's a project to direct towards Python core - which unfortunately puts it out of scope for Django. * I'm not convinced that a runner to help run all database backends at once is ultimately that helpful - I wouldn't have considered the burden of running three different test runs (or relying on the CI server, which does this for you) was sufficiently onerous to warrant spending time on the problem. * Regarding schedule - I've said this in other threads, and I appreciate that this is a first cut proposal -- but I'm *deeply* sceptical of any proposal that contains estimates of granularity > 2 weeks. The bulk of your timeline is in a 5 week block and a 4 week block - but you haven't provided any evidence that 5 weeks is an appropriate amount of time for the work provided, rather than just a number that adds up nicely to 12 weeks. Yours, Russ Magee %-) On Wed, Mar 25, 2015 at 9:18 AM, Varun Sharma <va...@sharmalabs.org> wrote: > Hi All, > > I've been writing this proposal from past few days. After going through > the pycon talks of Carl Meyer and Julien Phalip on Django's testing > framework and working on the test framework from last 2 months, I have > drafted some improvements but I'm not sure about any roadblocks or > feasibility issues that may arise during the implementation. In order to > minimise that, I request you all to have a look at the proposal and help me > out on the feasibility issues. I'd really appreciate any kind of feedback > and will do the required changes accordingly. > > Proposal: https://gist.github.com/varunsharma/597058c5da51d86698e3 > > > Thanks > Varun > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAJ7sbhEcj4uCk9U0%3DwbMY8wV1J0wQRjcma703W_%2BMe%2Br0Gmj%2BA%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAJ7sbhEcj4uCk9U0%3DwbMY8wV1J0wQRjcma703W_%2BMe%2Br0Gmj%2BA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJxq84-HXigucbZdnisN3xwi4E96RDMr3HNWdUGFPznvaKPUxw%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
