I think this is likely a good plan. There are a number of other places where we globally register converters/adapters (at least in postgres land) rather than explicitly registering them on each connection. I'm not sure if they're an issue in the same way though.
Marc On 13 April 2015 at 20:11, Carl Meyer <c...@oddbird.net> wrote: > On 04/13/2015 12:13 PM, Aymeric Augustin wrote: > [snip] > > Do you think the backwards-incompatibilities are acceptable? > > I think so, yes. It really isn't good behavior for Django to be > automatically installing such global adapters and converters. > > Perhaps the release notes documenting this backwards-incompatible change > could also provide sample code for users to install these > adapters/converters themselves, in order to restore the previous > behavior, if they are using datetimes in raw SQL queries with > cursor.execute()? > > It would also be possible to put the silent-data-loss aspect of this > change through a deprecation path, by having the existing adapters raise > a deprecation warning on receiving any non-UTC aware datetime for a > couple releases (presuming the ORM is updated to always send only UTC, > the adapter should only receive non-UTC on direct cursor.execute()). > > Carl > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/552C14C9.90200%40oddbird.net > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMwjO1EUzoj5gCm6jiHP0xsHB9Mpx4FezZBzvfeziqTJob0iWA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
