Thanks everyone for the useful feedback. I've created a ticket where the development of the idea can continue: https://code.djangoproject.com/ticket/25604
On Fri, Oct 23, 2015 at 7:33 AM, Chris Foresman <fores...@gmail.com> wrote: > Jon, > > You proposal seems like a sane and welcome change that aligns the exit > status of --exit with long-standing convention. > > > Thanks, > Chris > > > > On Wednesday, October 21, 2015 at 10:20:09 AM UTC-5, Jon Dufresne wrote: >> >> On Tue, Oct 20, 2015 at 9:29 PM, Gavin Wahl <gavi...@gmail.com> wrote: >> > In your case, successfully creating a migration indicates a failure. >> >> Only if the --check flag is on. The --check flag indicates that one is >> explicitly checking that all model changes have migrations. A non-zero >> exist status indicates that migrations were missing. If you feel the >> help text could be improved to communicate this, I can work towards >> that. >> >> > Why do you object to using a ! to communicate this? >> >> With the --check flag or the --exit flag? >> >> I think I covered this in the OP. But just to clarify: >> >> My use case: >> >> Continuous integration server check's developers' commits for >> correctness. One aspect of correctness is that all model changes have >> migrations. >> >> In shell scripting and CI servers an exit status of 0 indicates >> true/pass and an exit status of non-zero indicates false/failure. >> >> Therefore, the command should return 0 when everything is OK and >> correct and non-zero otherwise. Commits are correct when all model >> changes are accounted for. >> >> The current --exit behavior, returns non-zero when everything is >> correct. To account for this in CI, one must negate the exit status >> with !, this goes against conventional behavior. >> >> Further, if something goes terribly wrong and there is an unhandled >> exception, negating the exit status will make the CI stage appear to >> pass. This is backwards! CI can't tell the difference between "all >> changes accounted for" and "Python had an unhandled exception". >> >> >> Cheers, >> Jon > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at http://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/4a641f83-2334-4f64-b9d5-438c094dbe27%40googlegroups.com. > > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CADhq2b7ajz50vU_NEpwmQ8F8%3DmyVo-pKGoOkTDYbL90LrN7tYg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
