On 2015-11-22 21:31, Riccardo Magliocchetti wrote:
Hi Florian,
Il 22/11/2015 21:14, Florian Demmer ha scritto:
Hi guys,
i am confused/surprised by this ticket and already merged feature. it
took me a
while to find out what was happening in my admin:
https://code.djangoproject.com/ticket/14497
- it was merged into 1.8, right? the ticket says 1.2.
That was set at the time of filing the issue supposedly
It's pretty clear it has been applied to master and then backported:
https://code.djangoproject.com/ticket/14497#comment:32
yeah, i know. i found the ticket by finding the code and finding the commit.
i was just wondering if the version should be updated on merge. it would
be easier to track down changes, when the merge-version is set on the
ticket, especially when the change is minor and not in the releasenotes.
But i see now, that i misunderstood the field:
https://docs.djangoproject.com/en/1.8/internals/contributing/triaging-tickets/#version
Both change_list and change_view (for read-only fields) use
`display_for_field()`, that's why both are affected by the change.
That might
not have been on purpose...
I usually don't break software on purpose :)
did not mean the "breaking" part, just that changing it in one place had
an effect on both admin views... sorry if it sounded like that!
Imho, the automatically added link to the file should *not* have
precedence over
`list_display_links` and definitely should *not* break the
automatically added
link to the change_view, when the `FileField` happens to be first in
`list_display`.
What do you think?
Since you seem to care about this, any chance to open a pull request?
The pull request should contain updated tests to verify that the
double <a> link is fixed please. If not i'll give a try of fixing it
later this week.
since both admin views use that same function, i am not sure how easy it
will be to fix without adding a whole bunch of more code just to detect
the field type and checking list_display_links etc... i'll probably not
find the time to look into that until next weekend either.
as a workaround i have added the 'id' field in first place to my
list_display.
br
Florian
--
You received this message because you are subscribed to the Google Groups "Django
developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/56522D59.4020907%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
