Thanks for the advice, I started trying moving form-related stuff from FieldBase into a new ModelFormFieldBase class, and it turns out that there's a lot more we could, or should, move than just value_from_object and save_form_data.
Why not move out everything that couples the form field and the model field in from FieldBase into ModelFormFieldBase while we're at it ? I like this idea, are you more interrested in seeing a before / after of 0. just moving value_from_object + save_form_data or 1. moving form stuff from FieldBase into ModelFormFieldBase ? -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CALC3Kaf0g9%2B3FTibtYyi2_2AW%2BSmD8jYD6oCYYXTeSh_gN4DUA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.