Hi, Le lundi 27 juin 2016, Reinout van Rees a écrit : > > (You must) "add password validation to prevent the usage of..."! > > "It might be better to think of it as...": it is exactly this extra > thinkwork that everyone reading the messages has to do. We write it once and > read it many times: what should we optimize for? > In our source code, the answer is clearly that you should optimize for > readability. > Why is it suddenly different for commit messages?
The first persons reading the commit messages are the persons reviewing the pull requests and for them, it is quite natural to see the commit message as "(If merged, this will) fix foo". Even for someone reading the commits after they have been merged, when they are clearly history, it's not particularly complicated to read them as "(This commit did) fix foo". While this looks like some extra thinkwork, I don't think it's particularly problematic, and it's defininetely not on the scale of unreadable code. Whatever the tense used, if the commit message has the required information, the reader will figure it out. I have no special preference, but this thread pointed me towards some widely agreed convention and I'm thankful for that since I tend to always hesitate when writing a commit message. Now I will stick to the git convention. Cheers, -- Raphaël Hertzog ◈ Writer/Consultant ◈ Debian Developer Discover the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/20160627102828.GA22531%40home.ouaza.com. For more options, visit https://groups.google.com/d/optout.
