Hey, thanks for posting this here. I opened https://code.djangoproject.com/ticket/26888 to keep track of this. Can I get somebody with threading experience in Python tell me if your proposed patch makes sense?
Also, I marked this as a release blocker for 1.10 as I introduced this during a patch for another issue https://code.djangoproject.com/ticket/24931 /Markus On Sun, Jul 10, 2016 at 11:47:35PM -0700, a.bra...@rataran.com wrote:
Hello everyone.
As suggested by Markus on django-users group, I'm posting this here too.
-------
I'm using django (1, 10, 0, u'beta', 1).
When I try to reverse url in shell everything goes fine.
When under nginx/uwsgi with many concurrent request I get
... /local/lib/python2.7/site-packages/django/urls/resolvers.py", line 241,
in reverse_dict
return self._reverse_dict[language_code]
KeyError: 'it'
After a wile I figured out that RegexURLResolver is memoized by
get_resolver and so it acts like a singleton for a certain number of
requests.
Analyzing the code of RegexURLResolver I found that the method _poupulate
will return directly if it has been called before and not yet finished.
...
def _populate(self):
if self._populating:
return
self._populating = True
...
if used for recursive call in a single thread this will not hurt, but in my
case in uwsgi multi thread mode I got the error.
here is my quick and dirty fix:
class RegexURLResolver(LocaleRegexProvider):
def __init__(self, regex, urlconf_name, default_kwargs=None,
app_name=None, namespace=None):
...
self._populating = False
self.RLock = threading.RLock()
...
def _populate(self):
if self._populating:
self.RLock.acquire()
self.RLock.release()
return
self._populating = True
self.RLock.acquire()
...
self._populating = False
self.RLock.release()
Does anyone know if there is a better solution?
Thank you.
--
You received this message because you are subscribed to the Google Groups "Django
developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/308c7d89-27e5-4841-85b1-55b0584cef3b%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
-- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/20160711204150.GE11144%40inel.local. For more options, visit https://groups.google.com/d/optout.
signature.asc
Description: PGP signature
