I think this has cleaned up to request input (I'm a bit zealous to make something that will be merged). I left a note in 1.11.txt but when 2.0.txt is introduced, I'll move it there. Also, now everything is in places that are not PostgreSQL-only. I realized in the process that the only thing the list of functions in the features-list of a backend is to prevent the test suite to run tests for unsupported functions. Mostly because MariaDB won't include FIRST_VALUE and LAST_VALUE and a few more. Perhaps a single list would be better?
I have a few questions to clear this up before asking for a more formal review: 1. PostgreSQL and MariaDB don't include support for RESPECT|IGNORE NULLS for certain functions (details are provided in https://www.postgresql.org/docs/current/static/functions-window.html). Any thoughts if adding ignore_nulls=False|True to the constructor would be an idea, and then specify it's only possible for Oracle, or "as_oracle" with a special template? I noticed that nulls_last and nulls_first was added to OrderBy, however that is valid in all implementations. The Oracle virtual box was too big to fit on my machine, so I haven't tested locally for more than PostgreSQL, and on Python 3. 2. About __repr__ and __str__, in general, I'm in doubt what would be good ways to represent things, and how to test them? Also, I am in doubt what are intuitive input values that translate to CURRENT ROW, UNBOUNDED FOLLOWING etc.? I had a look at sqlalchemy which uses a mix of null-values and integers as valid input. In general, the frames-part is a bit of headache, and still slightly messy (the generated SQL is fine, so I suppose the current test data is adequate). And probably, django/db/backends/mysql/features.py should be left untouched? I know 1.11 is in the works, so I'm fine with this being on hold. Thank you, ~ Mads -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/822595ee-e75e-4979-8873-7b6488ee2d31%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
