I can't see any rationale for it on the ticket, PR, or mailing list
discussion
<https://groups.google.com/forum/#!topic/django-developers/VmF6m-NZeKg>.
The original implementation in the PR
<https://github.com/django/django/pull/568/files#diff-8f2277381e0c4f436ef7a782b4ef79abR178>
actually raised if settings.DEBUG:
if settings.DEBUG:
raise
else:
return None
But this was removed in merging
<https://github.com/django/django/commit/b7bd7087e6480c6a071a12ce20b389a8c225e908>
by Marc.
I'm +1 on removing the try/except because I think broken things should fail
obviously.
On 19 January 2017 at 13:56, Alasdair Nicol <alasd...@thenicols.net> wrote:
> On Thursday, 19 January 2017 12:17:49 UTC, Grzegorz Tężycki wrote:
>>
>> I think, that method get_redirect_url should raise ImproperlyConfigured
>> error with message "Reverse for 'xxxx' not found.", or NoReverseMatch
>> exception not should be catch.
>>
>
> I would prefer to stop catching NoReverseMatch, rather than raising
> ImproperlyConfigured. I think that
>
> RedirectView(pattern_name='view-does-not-exist').as_view()
>
> should have the same behaviour as
>
> RedirectView(url=reverse_lazy('view-does-not-exist')).as_view()
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/django-developers/004e6f3e-e750-47dd-8469-
> baf799933fe0%40googlegroups.com
> <https://groups.google.com/d/msgid/django-developers/004e6f3e-e750-47dd-8469-baf799933fe0%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
>
> For more options, visit https://groups.google.com/d/optout.
>
--
Adam
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/CAMyDDM18Y-W4_tSqpda6c%2BQfQqNPyNdhAoKNVDjvc-WJ0UnV-A%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
