Since that's a release blocker for a feature that hasn't been released yet, it's fine to reference/reopen the original ticket rather than create a new one. I've created a PR, https://github.com/django/django/pull/8034.
On Wednesday, February 8, 2017 at 7:40:02 AM UTC-5, Adam Johnson wrote: > > Pretty sure this is a new ticket since it's effectively a bug report > > On 8 February 2017 at 11:00, Mads Jensen <m...@inducks.org <javascript:>> > wrote: > >> >> >> On Wednesday, February 8, 2017 at 11:32:22 AM UTC+1, Adam Johnson wrote: >>> >>> Sounds legit, make a ticket >>> >> >> Shouldn't https://code.djangoproject.com/ticket/26610 just be reopened? >> >> >>> On 8 February 2017 at 00:37, Sean Brant <brant...@gmail.com> wrote: >>> >>>> I noticed the new postgres citext[1] field is a subclass of CharField. >>>> Wouldn't it be more correct to subclass TextField? Subclassing CharField >>>> means we need to add a max_length which is ignored in the db. >>>> >>>> [1] >>>> https://github.com/django/django/blob/master/django/contrib/postgres/fields/citext.py >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Django developers (Contributions to Django itself)" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to django-develop...@googlegroups.com. >>>> To post to this group, send email to django-d...@googlegroups.com. >>>> Visit this group at https://groups.google.com/group/django-developers. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/django-developers/0e50eae1-8806-47fc-b223-9cac7152bf1e%40googlegroups.com >>>> >>>> <https://groups.google.com/d/msgid/django-developers/0e50eae1-8806-47fc-b223-9cac7152bf1e%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Adam >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to django-d...@googlegroups.com >> <javascript:>. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/e2be5fd6-3fc0-44d5-8d07-da713eb58db4%40googlegroups.com >> >> <https://groups.google.com/d/msgid/django-developers/e2be5fd6-3fc0-44d5-8d07-da713eb58db4%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Adam > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/cac9ac5f-cdcd-4e33-bba3-b1a9de700365%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
