Doesn't sound like there's much impetus either way, and it's confusing
people, so I'd say remove it. Or maybe make it optional, default off?

On 19 March 2017 at 07:52, Tim Martin <t...@asymptotic.co.uk> wrote:

> I don't have any objection to removing this. However, the thought occurs
> that my patch to the handling of undefined variables could enhance this to
> make it more useful. I think we could log in the case where a conditional
> expression actually depends on an undefined variable. I haven't thought
> about it properly, but presumably the expression evaluation can even take
> account of short-circuiting, so that:
>
>   {% if defined_value or some_undefined_value %}
>
> correctly warns only in the case where defined_value is false. Of course,
> this won't help in the case of the admin template example you gave, where
> the conditional depends directly on the undefined value.
>
> The obvious drawback is that I think my patch is going to be abandoned, so
> I think this is a purely theoretical possibility. But if anyone likes the
> sound of it I can think through it a little more carefully.
>
> Tim
>
> --
> You received this message because you are subscribed to the Google Groups
> "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to django-developers+unsubscr...@googlegroups.com.
> To post to this group, send email to django-developers@googlegroups.com.
> Visit this group at https://groups.google.com/group/django-developers.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/django-developers/5cf29e82-19d7-4567-b537-
> 21a77faf88a9%40googlegroups.com
> <https://groups.google.com/d/msgid/django-developers/5cf29e82-19d7-4567-b537-21a77faf88a9%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
>
> For more options, visit https://groups.google.com/d/optout.
>



-- 
Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers  (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-developers+unsubscr...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-developers/CAMyDDM0Z-baLDh_wu59qjCxrVy%3D3xq_4xCdxP8nhZfNhL2zxew%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to