Thanks for the feedback. I think the indentation changes are correct, but please leave a comment on the PR so I can be sure which lines you're referring to. I added this text to the release notes per your suggestion:
The ``django.conf.urls.url()`` function from previous versions is now available as :func:`django.urls.re_path`, however, the old location remains for backwards compatibility, without an imminent deprecation. The old ``django.conf.urls.include()`` function is now importable from ``django.urls`` so you can use ``from django.urls import include, path, re_path`` in your URLconfs. On Wednesday, September 20, 2017 at 5:15:03 AM UTC-4, contact wrote: > > Hi Tim, > > I've taken a look at this one: > https://github.com/django/django/pull/9072 - Simplified URL routing > syntax. (docs) > > Seems good to me (there are some indentation changes, like in > docs/ref/contrib/sitemaps.txt > <https://github.com/django/django/pull/9072/commits/556d7a527636a6e7a73642b7f8654e4d844226b6#diff-083e9ed1a53be195444ef4656ddc6d3f> > > that are not systematic in the urlpatterns, but I don't know if it's > important). > > I would just have added something in docs/releases/2.0.txt > <https://github.com/django/django/pull/9072/commits/556d7a527636a6e7a73642b7f8654e4d844226b6#diff-af003fcfed7cfbdeb396f8647ed0f92f> > > to tell that previous behaviour (with url()) has been moved to > django.urls.re_path(). > If I understood it well at least... There might be cases where the new > syntax won't be sufficient (or at least I believe so, like in urls like > /ab/cd/abcdefghi for example), and pushing upgraders to start using > re_match directly instead of url() might be a good idea, IMHO. Does it > make sense or did I miss something? > > - Brice > > Le 20/09/17 à 04:21, Tim Graham a écrit : > > I spent today finishing up writing and then reviewing the documentation > for URL routing. I'll give that and the code one more look tomorrow before > merging. In the meantime, other reviews (especially from anyone less > familiar with the feature) are certainly welcome. > https://github.com/django/django/pull/7482 - Simplified URL routing > syntax. (code) > https://github.com/django/django/pull/9072 - Simplified URL routing > syntax. (docs) > > <https://github.com/django/django/pull/9086> > other todos for the alpha: > https://github.com/django/django/pull/9086 - Refs #28595 -- Added execute > wrappers for database queries. > https://github.com/django/django/pull/9081 - Fixed #27332 -- Added > support for conditional joins in the ORM. > > On Monday, September 18, 2017 at 9:44:05 PM UTC-4, Tim Graham wrote: >> >> completed today: >> https://github.com/django/django/pull/6385 - Fixed #14370 -- Added >> select2 widget for related object fields in admin. >> https://github.com/django/django/pull/7611 - Fixed #26608 -- Add support >> for OVER-clause (window expressions). >> >> <https://github.com/django/django/pull/7482> >> todo: >> https://github.com/django/django/pull/7482 - Simplified URL routing >> syntax. (code) >> https://github.com/django/django/pull/9072 - Simplified URL routing >> syntax. (docs) >> https://github.com/django/django/pull/9086 - Refs #28595 -- Added >> execute wrappers for database queries. >> https://github.com/django/django/pull/9081 - Fixed #27332 -- Added >> support for conditional joins in the ORM. >> >> On Sunday, September 17, 2017 at 5:11:43 PM UTC-4, Florian Apolloner >> wrote: >>> >>> Looks good to me. >>> https://github.com/django/django/commit/01c6a3e227b645e8dea97e9befecd23d1d3b8581 >>> >>> resulted in test failures, we might have to revert that. >>> >>> I do have to add https://github.com/django/django/pull/9100 to the mix, >>> but since it is a bugfix we can easily do this after the alpha. >>> >>> cheers, >>> Florian >>> >>> On Sunday, September 17, 2017 at 1:30:01 AM UTC+2, Tim Graham wrote: >>>> >>>> Time to kickoff the progress tracker for the next major release! >>>> >>>> The 2.0 alpha is scheduled (according to >>>> https://code.djangoproject.com/wiki/Version2.0Roadmap) for Monday, >>>> September 18. Typically we've release the alpha a few days later to finish >>>> up a few last minutes things. Here are the PRs on my list to polish off >>>> before the alpha release. I'll send another update on Monday. >>>> >>>> https://github.com/django/django/pull/6385 - Fixed #14370 -- Added >>>> select2 widget for related object fields in admin. >>>> https://github.com/django/django/pull/7611 - Fixed #26608 -- Add >>>> support for OVER-clause (window expressions). >>>> https://github.com/django/django/pull/7482 - Simplified URL routing >>>> syntax. (code) >>>> https://github.com/django/django/pull/9072 - Simplified URL routing >>>> syntax. (docs) >>>> https://github.com/django/django/pull/9086 - Refs #28595 -- Added >>>> execute wrappers for database queries. >>>> https://github.com/django/django/pull/9081 - Fixed #27332 -- Added >>>> support for conditional joins in the ORM. >>>> >>> >>> -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] <javascript:>. > To post to this group, send email to [email protected] > <javascript:>. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/d7b7a5bd-26ad-4763-9da4-22c477b2ac1c%40googlegroups.com > > <https://groups.google.com/d/msgid/django-developers/d7b7a5bd-26ad-4763-9da4-22c477b2ac1c%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > > > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/938ea893-cc25-4744-a747-c700da069a36%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
