I agree about deprecating PASSWORD_RESET_TIMEOUT_DAYS, with no rush to remove. Then if PASSWORD_RESET_TIMEOUT it takes precedent. Now for the input to PASSWORD_RESET_TIMEOUT looking at current settings in django, anything I found that is time/age based is expressed in integer seconds. I would say stay with seconds,
Dylan On Wed, Sep 20, 2017 at 7:56 PM, Zhiqiang Liu <zachliu...@gmail.com> wrote: > I need general consensus on how to proceed with supporting password expire > time to be under a day. Currently it is not possible because we use > PASSWORD_RESET_TIMEOUT_DAYS. > > In ticket 28622 <https://code.djangoproject.com/ticket/28622> we have two > options. > > One is to continue to use the same setting PASSWORD_RESET_TIMEOUT_DAYS, > but change the value to non-integer (such as timedelta) so we can send > hours, minutes, etc to it. > > The other one is to create a new setting like PASSWORD_RESET_TIMEOUT which > takes seconds.To support backward compatibility, I think we should keep > PASSWORD_RESET_TIMEOUT_DAYS and its default value of 3. Only use > PASSWORD_RESET_TIMEOUT when provided. > > I'm unsure which one is better, so inputs are welcome. > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit https://groups.google.com/d/ > msgid/django-developers/c8e96008-eb95-4924-8e5e- > 9b02d6b90c99%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/c8e96008-eb95-4924-8e5e-9b02d6b90c99%40googlegroups.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAHtg44B_yZrfeY%3DrwS%3DzjpyUwY%3DbJCSH6DXGD24%3DNP3nyiqeHg%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
