Hi Adam, no I would not take any of his code. I would certainly contact him as a reviewer or co-author of a possible patch.
In general I would like to consolidate the two middlewares into a single response compression middleware that support multiple algorithms. All except gzip would require users to install additional dependencies. But I believe this to be acceptable. Same as you need to install Pillow if you want Image support in Django. Best -Joe On Friday, September 14, 2018 at 11:31:43 AM UTC+2, Adam Johnson wrote: > > Sounds like a good idea to me. > > Would you be looking at merging any code from django-brotli, and have you > been in contact with its creator and license holder Vasek Dohnal? > > And what kind of methods around Accept-Encoding are you imagining? > > On Fri, 14 Sep 2018 at 09:01, Johannes Hoppe <in...@johanneshoppe.com > <javascript:>> wrote: > >> Hi there, >> >> we all know the the wonderful GZip middleware that allows response >> compression. Which is great especially if you are serving large responses. >> >> Now gzip is only one of many supported encoding types supported by many >> browsers. The coolest kid on the block seems to be brotli right now. >> It is both faster and smaller in most cases then gzip and has been >> standardized in https://www.ietf.org/rfc/rfc7932.txt >> >> Of course there is already a package that adds brotli support to Django: >> https://pypi.org/project/django-brotli/ >> >> But I would propose to refactor the GZip middleware into something like >> "CompressionMiddlware" and add support for both GZip and Brotli >> in the same middleware. >> >> I have the feeling something basing like response encoding should be >> build into Django. Of course I would not add a hard dependency to brotli, >> but add all methods to `Accept-Encoding` that are actually installed. >> >> What do you guys think? Is this worth a little refactoring? >> >> Best >> -Joe >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-develop...@googlegroups.com <javascript:>. >> To post to this group, send email to django-d...@googlegroups.com >> <javascript:>. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/29cf5142-fa82-4d74-9d8f-5fb0c8be34d0%40googlegroups.com >> >> <https://groups.google.com/d/msgid/django-developers/29cf5142-fa82-4d74-9d8f-5fb0c8be34d0%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > > > -- > Adam > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/7b2c1967-ad49-42c6-967e-f91ec0e41a5e%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
