If the other fields are also 191, i see no reason not to make the change. It should be a non-breaking change. And Yes i am that colleague...
On Tuesday, November 13, 2018 at 4:52:24 PM UTC+1, Tim Allen wrote: > > Greetings, > > Over the past few releases, several CharFields in django.contrib.auth > have been increased to a max_length of 191: username, first_name, and > last_name > immediately come to mind. > > See: > https://groups.google.com/forum/#!msg/django-developers/h98-oEi7z7g/xzjtFMf1BwAJ > > I've issued a PR to extend Group.name to the same length here: > https://github.com/django/django/pull/10627 The original ticket this is > addressing was from a colleague who was bumping into the limit when syncing > groups to Django from LDAP: https://code.djangoproject.com/ticket/29939 > > The 191 character limit was chosen to support MySQL index limits. > > Can anyone think of a reason not to change Group.name to be max_length=191 > as we have with the other fields? > > Regards, > > Tim > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/1f00582c-452c-4d56-9450-967a31818bea%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
