Hi all, I'm working on https://github.com/django/django/pull/10786 (which is a port of https://pypi.org/project/django-service-urls/ , which is a 'fork/rewrite' of Tom PR). I need to (re)read all these emails to find ideas to improve the PR/package.
On Sat, Jul 28, 2018 at 9:44 PM Tom Forbes <t...@tomforb.es> wrote: > So in the PR I proposed I only bits I took verbatim from dj-database-url > are the tests. The rest is re-implemented. I think it's a pretty good POC > but I haven't touched it in a while. > > In any case we have to implement our own parsing for backends that do not > support passing in a URL to the connection library. > > Making postgres skip our parsing step and passing it in directly is an > implementation detail and there are much more important questions around > the API design to answer before this has any chance of being included. > > On Sat, 28 Jul 2018, 12:57 Maciej Urbański, <rooter....@gmail.com> wrote: > >> I would agree that DSN support seems like a nicer alternative to just >> copying dj-database-url, because it not only focuses on 12factor >> configuration in enviroment variables, but also enables some additional >> flexibility for the database connection option passing. >> >> As for 12factor, I think https://gist.github.com/telent/9742059 is a >> good read as to why exposing as enviroment variables maybe not the best >> motivation. Having to accommodate settings, like database connection >> information, just so they can be fitted into single string put conveyable >> by enviroment variable is a case in point. We likely can do the same for >> Cache addresses as mentioned previously, although we may end up inventing >> new URI schemes do to that.., but django overall has multitude of other >> options that are not as easy to stringify. >> >> On Friday, 27 July 2018 19:14:12 UTC+2, gw...@fusionbox.com wrote: >>> >>> I'd like to approach this as 'support database urls in django', rather >>> than 'copy/paste dj-database-url into django'. For postgres (I'm not sure >>> about other backends), a database url can be passed directly to psycopg2. >>> The postgres connection string format actually supports more features than >>> is possible with django's HOST/USER/PORT... style settings. For example, >>> you can pass multiple hosts and psycopg2 will attempt to connect to one of >>> them: https://paquier.xyz/postgresql-2/postgres-10-multi-host-connstr/. >>> Any attempt to parse the url in django will result in a loss of those >>> features. >>> >>> The only problem I see is that we have to parse the database backend out >>> of the url, and you can't pass a url like 'postgis://....' to psyscopg2. >>> I'd like to be able to do something like: >>> >>> DATABASES = { >>> 'default': { >>> 'DSN': 'postgres://....', >>> 'ENGINE': 'django.contrib.gis.db.backends.postgis', >>> }, >>> } >>> >>> And let psycopg2 handle the DSN. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers (Contributions to Django itself)" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to django-developers+unsubscr...@googlegroups.com. >> To post to this group, send email to django-developers@googlegroups.com. >> Visit this group at https://groups.google.com/group/django-developers. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/django-developers/1a55cc1c-ba9c-4950-ab94-50da8eec7d06%40googlegroups.com >> <https://groups.google.com/d/msgid/django-developers/1a55cc1c-ba9c-4950-ab94-50da8eec7d06%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To post to this group, send email to django-developers@googlegroups.com. > Visit this group at https://groups.google.com/group/django-developers. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/CAFNZOJMa1xSzBeGUYygG7nxfCVz8jUPNEiSEJhbAqLDTwga9BQ%40mail.gmail.com > <https://groups.google.com/d/msgid/django-developers/CAFNZOJMa1xSzBeGUYygG7nxfCVz8jUPNEiSEJhbAqLDTwga9BQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- | Raffaele Salmaso | https://salmaso.org | https://bitbucket.org/rsalmaso | https://github.com/rsalmaso -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at https://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABgH4JvV_Qe%3DV7ZW4jdk%2BhH57hrQ-Pi%2B%3DHa5Wxpqi6aVXDFo-A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
