Hi all,
As a long time Django user, I often found the requirement to use login or
force_login somewhat cumbersome.
In comparison, pylons' WebTest has a user keyword argument e.g in their get
method,
which does that authentication inline.
I am suggesting we make a call to login or force_login if a related
argument is passed. Something akin to this:
diff --git a/django/test/client.py b/django/test/client.py
index c460832461..b0a3f89c60 100644
--- a/django/test/client.py
+++ b/django/test/client.py
@@ -726,8 +726,10 @@ class Client(ClientMixin, RequestFactory):
self.cookies.update(response.cookies)
return response
- def get(self, path, data=None, follow=False, secure=False, **extra):
+ def get(self, path, data=None, follow=False, secure=False, user=None,
**extra):
"""Request a response from the server using GET."""
+ if user:
+ self.force_login(user)
self.extra = extra
response = super().get(path, data=data, secure=secure, **extra)
if follow:
I would love to discuss this suggestion with the rest of you, hopeful to
get some more ideas or an agreement or sorts.
And later, if this is agreed to be useful to the community, I could work on
the PR.
Kind Regards,
Pavel
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-developers/d5185a29-4ded-4966-87b3-1149c970eec5%40googlegroups.com.
