I'm not an expert or even an amateur at the ORM, but here are my thoughts on the matter: 1. Does it carry over well across the four databases? 2. Is it necessary to include it as part of core versus a third-party app? 3. What specific use case will benefit from adopting this idea?
I ask the second question because it seems from your gist that you don't need your proposal to be part of core for it to work. It seems it would work completely well and flourish even as a third-party app given how you're subclassing the API and expanding on its usage. Contrast this with django-pytest for example that can have a harder problem running pytest on Django due to how the test runner is currently built (namely that setup assumes a subclass of the Django test runner). Regards, Ahmad On Sun, May 17, 2020 at 4:36 PM Petr Přikryl <nich...@gmail.com> wrote: > Hi, I have just implemented Table Function support on Django 2.1. What do > you think about adopting it into Django itself? > > https://gist.github.com/petrprikryl/7cd765cd723c7df983de03706bf27d1a > > It is all about passing function parameters into BaseTable and Join > classes > https://github.com/django/django/blob/master/django/db/models/sql/datastructures.py > > Here are other thoughts which were inspiring me > https://schinckel.net/2019/10/31/functions-as-tables-in-django-and-postgres/ > > Thanks, > Petr > > -- > You received this message because you are subscribed to the Google Groups > "Django developers (Contributions to Django itself)" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to django-developers+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/django-developers/6d16fdfc-332f-4a72-83ae-04ee5c9fd28a%40googlegroups.com > <https://groups.google.com/d/msgid/django-developers/6d16fdfc-332f-4a72-83ae-04ee5c9fd28a%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJNa-uPBFBhOyrMB9X97wVU12Hk6%2Bn7Jy8qSXhZr6-jGn9mOsQ%40mail.gmail.com.
