KimSoungRyoul it looks like there is feedback on the PR you created (PR #12605 <https://github.com/django/django/pull/12605>) and Marius also pointed out that docs and tests are missing. Would you like help with the docs and tests? We've recently added some data scientists and dbas to our team and I immediately saw the significant value in ticket 28822 <https://code.djangoproject.com/ticket/28822>. You're marked as the ticket owner right now, but I'd love to help out with docs and tests if you feel that the rest of the implementation is solid (or if you are willing to update your PR based on the feedback from Mads Jensen (atombrella). *(Full disclosure: I'm new to contributing to django, but hoping that this can be my first contribution. I've been thankful to use Django at work for 9 years now!)*
On Saturday, May 2, 2020 at 10:24:46 PM UTC-7 kimsou...@gmail.com wrote: > I'm sorry if I sounded like I was pushing you. > > even missing checklist > > > 2020년 5월 3일 일요일 오전 1시 42분 2초 UTC+9, Mariusz Felisiak 님의 말: > >> Asking for a review on multiple channels doesn't help. You need to be >> patient, we have many PRs in review queue. Please check "Patch review >> checklist" [1]. At first glance, docs are missing. >> >> [1] >> https://docs.djangoproject.com/en/3.0/internals/contributing/writing-code/submitting-patches/#patch-review-checklist >> > -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0f963398-7733-4cd6-9b5f-600945030b36n%40googlegroups.com.
