Hi Paul, > As some of you may be aware of, I've been working on improving the offer module for some time now. I cleaned up the proxy resolution, allowed multiple benefits per line item.
Thanks a lot of your efforts on this! > What I'm currently struggling with is two fields that touch on policy: offer.max_applications and benefit.max_affected_items I can't see any max_applications field/property on the Offer model - are you referring to max_basket_applications? max_basket_applications does indeed seem to be an attempt at achieving similar objectives to Benefit.max_affected_items . My best guess is that this was done to allow some degree of control without having to write a custom benefit class - which to be honest doesn't feel like very good justification, and you can easily end up with counter-intuitive results depending on how the benefit(s) used by a particular offer apply themselves. The Offer model also has max_global_applications, max_user_applications whose uses cases are fairly common for vouchers and/or limited-availability offers. I don't think these are contentious. > The proxy setup must go. Agree entirely on this. Samir -- https://github.com/django-oscar/django-oscar http://django-oscar.readthedocs.org/en/latest/ https://twitter.com/django_oscar --- You received this message because you are subscribed to the Google Groups "django-oscar" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-oscar+unsubscr...@googlegroups.com. Visit this group at https://groups.google.com/group/django-oscar. To view this discussion on the web, visit https://groups.google.com/d/msgid/django-oscar/a9d7176c-7e8f-4dc3-b8f8-afe15fc24125%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
