#15363: get_queryset & get_query_set
--------------------------------------+------------------------------------
     Reporter:  sorl                  |                    Owner:  loic84
         Type:  Cleanup/optimization  |                   Status:  assigned
    Component:  Core (Other)          |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  1
  Needs tests:  1                     |  Patch needs improvement:  1
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by loic84):

 * cc: loic84 (added)


Comment:

 Unless I'm missing the point, I think this decorator suffers from the same
 issue as mine: since all calls to `get_query_set` in Django core are
 changed to `get_queryset`, the user defined `get_query_set` will never be
 called.

 Also I went the method decorator route because there are a few more
 queryset getter inconsistencies such as `BaseModelAdmin.queryset`,
 `get_prefetch_query_set`, etc.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/15363#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to