#19517: Add support for X-Forwarded-Port to HttpRequest.get_host when
USE_X_FORWARDED_HOST is in use
-------------------------------------+-------------------------------------
     Reporter:  david_k_hess@…       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  HTTP handling        |                  Version:  1.4
     Severity:  Normal               |               Resolution:  wontfix
     Keywords:  httprequest,         |             Triage Stage:  Accepted
  get_host, X-Forwarded-Host,        |      Needs documentation:  0
  USE_X_FORWARDED_HOST               |  Patch needs improvement:  0
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  1                    |
-------------------------------------+-------------------------------------
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 I'm rejecting this after a discussion during the 2013 sprint:

 - The use case of handing a SSL request with a load balancer is handled
 already by the `SECURE_PROXY_SSL_HEADER` setting.

 - `HTTP_X_FORWARDED_PORT` is not a standard header and this ticket hasn't
 produced compelling evidence that Django is breaking any spec.

 - Adding a new setting pair of `HTTP_X_FORWARDED_PORT` and
 `USE_X_FORWARDED_PORT` just for this edge case is a no-go, too.

 In other words, the issue is an edge case that can be solved by a custom
 middleware in your application (e.g. by setting `HTTP_HOST`).

-- 
Ticket URL: <https://code.djangoproject.com/ticket/19517#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to