#19385: Add support for multiple-column join
-------------------------------------+-------------------------------------
Reporter: cseibert | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 1.4
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: join | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by akaariai):
I did a rebase of the patch. While working on the patch I saw three things
worth mention:
- Generally looking very good
- Unused imports, other PEP-8 code cleanup required
- Some naming issues in ForeignObject.*_related_fields (I find them a
bit hard to remember). The naming issues might be OK to postpone after
commit...
The rebase commit tells also what else apart of just making this run was
done. Most important change is using ForeignObject as base of
GenericRelation, too.
I was too lazy to do the rebase per commit, so the commits before HEAD
aren't passing tests.
I will be on holiday next week, but after that I think I will just do
final cleanup & commit. Polishing this outside master will just lead to
more rebase conflicts. Meanwhile, using SubqueryConstraint in
split_exclude() isn't forbidden... :)
Rebase available from:
https://github.com/akaariai/django/compare/ticket_19385_2_rebased
--
Ticket URL: <https://code.djangoproject.com/ticket/19385#comment:29>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
