#20221: `conditional_escape` does not work with lazy strings
---------------------------+--------------------------------------
Reporter: bmispelon | Owner: bmispelon
Type: Bug | Status: new
Component: Utilities | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------+--------------------------------------
Changes (by bmispelon):
* needs_better_patch: => 0
* has_patch: 0 => 1
* needs_tests: => 0
* needs_docs: => 0
Comment:
I added some tests for `conditional_escape` and tried to make them pass.
I think the `allow_lazy` decorator applied to `escape` was the issue here,
so I removed and added some special-casing of `Promise` objects in the
function itself.
Here's the branch I'm working on:
https://github.com/bmispelon/django/compare/ticket-20221
--
Ticket URL: <https://code.djangoproject.com/ticket/20221#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
