#14019: SQLInsertCompiler.as_sql() failure
-------------------------------------+-------------------------------------
     Reporter:  mlavin               |                    Owner:  tobias
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  1.2
  (models, ORM)                      |               Resolution:  wontfix
     Severity:  Normal               |             Triage Stage:  Design
     Keywords:                       |  decision needed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by carljm):

 Reopening after checking with Jacob on IRC. This is a code quality fix,
 and code quality matters in private APIs too.

 I don't like the patch using hasattr, but I think initializing `return_id`
 in `__init__` is a clear win.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/14019#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to