#17209: Dogfood class-based views in contrib.auth
-------------------------------------+-------------------------------------
Reporter: melinath | Owner: andrews
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: class-based views | Needs documentation: 0
admin auth | Patch needs improvement: 1
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by rockymeza):
I opened a pull request for this ticket
https://github.com/django/django/pull/1239
This pull request is different from
https://github.com/bmispelon/django/compare/auth-cbv in a couple ways:
1. There is no wrapper shim. The views extract the old parameters from
kwargs. This has the benefit of subclasses still supporting the old view
invocation.
2. It uses the DecoratorMixin pattern described in
https://groups.google.com/d/msg/django-
developers/jrfbenCJYYU/6aiH2sebnlAJ. This is controversial, yes, but it
does mean a subclass will never lose its decorators should someone
override dispatch.
3. It is rebased on master.
I was going to write some documentation for the class-based views, but I
was wondering if we should maintain (and keep documented) the function
view kwarg parameters or if they should be truly deprecated. All access
to those function view kwarg parameters is regulated through one piece of
code, so it would be possible to deprecate them easily. I'm in favor of
deprecating the function view kwargs, 1) because they are terribly
inconsistent (`post_reset_redirect` vs. `post_change_redirect`) and 2) to
embrace the established class-based views APIs.
--
Ticket URL: <https://code.djangoproject.com/ticket/17209#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.6600c9dea9a5fb011af58cb61009f8bd%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
