#19875: Tutorial should have include ALLOWED_HOSTS setting
-------------------------------------+-------------------------------------
     Reporter:  anonymous            |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |                  Version:  1.4
    Component:  Documentation        |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  ALLOWED_HOSTS,       |      Needs documentation:  0
  tutorial                           |  Patch needs improvement:  0
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  0                    |
Easy pickings:  1                    |
-------------------------------------+-------------------------------------

Comment (by timo):

 New patch adds logic so `runserver` won't serve any requests if `DEBUG` is
 `False` and `ALLOWED_HOSTS` is empty (I'm unsure if this needs tests --
 `tests.admin_scripts.ManageRunserver` mocks the `run` method so I don't
 think anything in that method is actually tested).

 Also removed the note in the previous patch from `settings.py`.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/19875#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.d7f6dc8add542eeb9dc42b9e8f376b56%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to