#3957: BRCPFField LocalflavorBR
-------------------------------------------+--------------------------------
Reporter: [EMAIL PROTECTED] | Owner: adrian
Status: new | Component:
django.contrib.localflavor
Version: SVN | Resolution:
Keywords: brcpffield, localflavor, br | Stage: Accepted
Has_patch: 1 | Needs_docs: 0
Needs_tests: 0 | Needs_better_patch: 1
-------------------------------------------+--------------------------------
Changes (by mtredinnick):
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
This class needs at least ''some'' documentation to explain what it does.
The fields in localflavor should at least be vaguely understandable to
people outside that locale and doing a Google search for BRCPF doesn't
turn up anything relevant in the first few hits. Please put a small
docstring at the top of the class explaining what the field is used for
(perhaps with a reference to an English-language web page explaining what
it is -- e.g. wikipedia -- if possible).
Also, you cannot use unicode strings inside gettext() reliably -- this is
a constraint in Python not in Django (although Django will soon add
ugettext() support). They will break if they contain non-ASCII
characaters. So best to remove the u"..." markers and just use normal
strings there.
--
Ticket URL: <http://code.djangoproject.com/ticket/3957#comment:7>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
