#19934: Switch to a Python 3-compatible imaging library -------------------------------------+------------------------------------- Reporter: aaugustin | Owner: Type: | daniellindsley Cleanup/optimization | Status: closed Component: Python 3 | Version: master Severity: Release blocker | Resolution: fixed Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+------------------------------------- Changes (by chrismedrela):
* cc: chrismedrela (added) Comment: I'm working on my GSoC project and I need to be sure what kind of exceptions may be raised while importing `django.utils.image`. Is it possible to end with an `ImportError`? There is one import statement which is not wrapped in try-except clause https://github.com/django/django/commit/33793f7c3edd8ff144ff2e9434367267c20af26a#L3R133. If it may fail, we should wrap it in try-except blocks and reraise as an `ImproprelyConfigured` exception. If not, then adding a comment why it can't happen would clarify the situation. For me it looks like it can't happen. If line 95 or 99 succeed then respectively line 131 or 133 must succeed too; otherwise an `ImproperlyConfigured` exception is being raised (line 102). Nonetheless, I'm not sure and I would like to hear your opinion. -- Ticket URL: <https://code.djangoproject.com/ticket/19934#comment:24> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.b3cfdf556dcaac62ebf0ff3d8a68860e%40djangoproject.com. For more options, visit https://groups.google.com/groups/opt_out.