#20619: Missing call to super in `WSGIRequest.__init__()`
-------------------------------+-----------------------------------------
Reporter: loic84 | Owner:
Type: Bug | Status: closed
Component: HTTP handling | Version: master
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage: Someday/Maybe
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
Changes (by jezdez):
* status: new => closed
* resolution: => invalid
* stage: Accepted => Someday/Maybe
Comment:
I've talked to loic84 on IRC and think there is no evidence that
refactoring this piece of code will lead to improving the code. The call
to super may be missing, but there is no feature on the horizon to my
knowledge (and to loic84's knowledge) that would require it.
Given the central role the HttpRequest class plays in *any application*
I'm closing this ticket as invalid and ask to reopen it if an actual use
case presents itself to make a sensible decision of the usefulness of this
refactor.
TLDR; uneeded code churn with high risk
--
Ticket URL: <https://code.djangoproject.com/ticket/20619#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.7d2d3bd8996b2ea2926e89deeed2e825%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
