#20773: contrib/gis/maps/google/gmap : script() string formating
----------------------------+--------------------
Reporter: martync | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+--------------------
The property named "script" in contrib.gis.maps.google.gmap.GoogleMap has
a wrong string formating.
https://github.com/django/django/blob/1.5c2/django/contrib/gis/maps/google/gmap.py#L134-L137
{{{
return format_html('%s\n <script
type="text/javascript">\n//<![CDATA[\n%s//]]>\n </script>',
self.api_script, mark_safe(self.js))
}}}
while it should be :
{{{
return format_html('{0}\n <script
type="text/javascript">\n//<![CDATA[\n{1}//]]>\n </script>',
self.api_script, mark_safe(self.js))
}}}
I have created a pull request for this bug :
https://github.com/django/django/pull/1379
I will write a testcase.
--
Ticket URL: <https://code.djangoproject.com/ticket/20773>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/050.19e1df25ba419cccbf54955d3e0b6a14%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
