#20980: Inconsistant MRO in BaseDateListView and BaseDayArchiveView
-------------------------------------+-------------------------------------
     Reporter:  django@…             |                    Owner:  nobody
         Type:                       |                   Status:  closed
  Cleanup/optimization               |                  Version:  1.5
    Component:  Generic views        |               Resolution:  wontfix
     Severity:  Normal               |             Triage Stage:
     Keywords:                       |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by mjtamlyn):

 * status:  new => closed
 * needs_better_patch:   => 0
 * resolution:   => wontfix
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 I would be generally worried about what you're trying to do here. There's
 a *lot* of pieces of functionality in this code you're trying to use at
 once. In particular, you've got both `SingleObjectMixin` and
 `MultipleObjectMixin` in your class hierarchy. Also, you've got multiple
 implementations of `get_dated_items`.

 This seems a heavy edge case to me. I think it's the territory you should
 be writing your own view rather than trying to to mix together the pieces
 Django provides. You may have more luck composing the lower level
 components of the views you're using at the moment so you have better
 control over the MRO.

 I'm going to close this, as we simply can't support every possible
 inheritance scenario. The patch is pretty innocuous, but the motivation is
 flawed.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/20980#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/087.9bfba859ada6066a1c64f14e2c8a3e6a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to