#21048: Error page should not invoke callables passed through WSGI META
structure
-------------------------------+------------------------------------
Reporter: ericbuehl | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by ericbuehl):
* easy: 1 => 0
Comment:
Continuation from closed pull request:
There is concern about the performance of looping over the META dict for
every request as the patch is currently implemented. As far as I can
tell, pep 333 does not make any mention of semantics around passing of
callables in the environ dictionary. I agree that this is a bit wonky for
Werkzeug to be doing this, but it's unacceptable for Django to be blindly
invoking that callable at any point. How about one of the following
options:
a) iterate through the META structure only when DEBUG==True
b) delay iteration until we enter the debug handler view
My vote is for option b. Thoughts?
--
Ticket URL: <https://code.djangoproject.com/ticket/21048#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.f251caca70c95f51acead9ed757be48c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
