Branch: refs/heads/master
  Home:   https://github.com/django/django
  Commit: 2ca00faa913754cd5860f6e1f23c8da2529c691a
      
https://github.com/django/django/commit/2ca00faa913754cd5860f6e1f23c8da2529c691a
  Author: Florian Apolloner <flor...@apolloner.eu>
  Date:   2013-09-22 (Sun, 22 Sep 2013)

  Changed paths:
    M django/core/management/commands/runserver.py
    M django/core/servers/basehttp.py
    M django/test/testcases.py
    M tests/servers/tests.py

  Log Message:
  -----------
  Fixed "Address already in use" from liveserver.

Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".

Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.



-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/523f4d24381bb_751e11e3d58472c7%40hookshot-fe2-pe1-prd.aws.github.net.mail.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to