#21172: have LiveServerThread follow the semantics of threading.Thread.join()
-----------------------------------+--------------------
     Reporter:  ldd                |      Owner:  nobody
         Type:  Bug                |     Status:  new
    Component:  Testing framework  |    Version:  master
     Severity:  Normal             |   Keywords:
 Triage Stage:  Unreviewed         |  Has patch:  0
Easy pickings:  1                  |      UI/UX:  0
-----------------------------------+--------------------
 File: `django/test/testcases.py`

 The semantics of `threading.Thread.join()` are "wait for this thread to
 end" and nothing more.

 However, `LiveServerThread` redefines these semantics to **first cause
 this thread to end** and then wait for this thread to end.

 This harms reusability, because someone calling `join()` on this object
 would expect the regular semantics and not the Django-specific
 redefinition. I've encountered this bug in 1.5 but visual inspection of
 `master` shows that at the time of writing this ticket it is present there
 too.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21172>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/046.1693a01c2d1ed2af74f84106406ec961%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to