#21271: Django's usage of smtplib.SMTP should have a timeout
--------------------------------------+------------------------------------
     Reporter:  edevil                |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Core (Mail)           |                  Version:  1.5
     Severity:  Normal                |               Resolution:
     Keywords:  smtp timeout          |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  1                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by edevil):

 Can't you use the global_setting in assertEqual(), so that the value isn't
 hardcoded?

 As for the backend, currently send_messages() already skips close() when
 _send() throws an exception. But in the case of timeouts, smtplib
 automatically closes the underlying connection.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21271#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.05e549d469e60e924e94d666d28c28ff%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to