#21363: TimestampSigner.unsign should accept a timedelta for max_age
--------------------------------------+------------------------------------
Reporter: gwahl@… | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by bmispelon):
* cc: bmispelon@… (added)
* needs_better_patch: 0 => 1
* component: Uncategorized => Core (Other)
* version: 1.4 => master
* needs_docs: 0 => 1
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Hi,
I think this is a good idea too and it makes for a nicer API.
You should follow the deprecation policy [1] on passing integers for
`max_age` so that we can phaze it out.
A full patch will also need a bit of documentation (at least amending the
current docs to indicate that a timedelta should be passed as well as a
note in the release notes for 1.7).
Thanks.
[1] https://docs.djangoproject.com/en/dev/internals/release-process
/#internal-release-deprecation-policy
--
Ticket URL: <https://code.djangoproject.com/ticket/21363#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/077.f98483de93fa95e173ef49486d24f530%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
