#18419: Language code is not correct for Chinese
-------------------------------------+-------------------------------------
Reporter: Olli Wang | Owner: bouke
<olliwang@…> | Status: new
Type: Bug | Version: 1.4
Component: | Resolution:
Internationalization | Triage Stage: Accepted
Severity: Normal | Needs documentation: 0
Keywords: i18n, chinese, zh | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by bouke):
* status: closed => new
* resolution: fixed =>
Comment:
After discussing on IRC we found that (1) some unit tests failed after the
patch and (2) the upgrade path to be somewhat bumpy. The problem occurs
when `LANGUAGES` isn't overridden and would contain both old and new
language codes. Now if a browser comes along and requests the old language
code (which might include the most recent versions of IE and Firefox),
Django will upgrade this old language code to the new language code. Now,
if there is some customization done for the old language codes, Django
would thus use the new language code and ignored the translations. To
mitigate `get_supported_language_variant` also needs to check if the old
language code is still in the list of supported languages.
PR: https://github.com/django/django/pull/1872
--
Ticket URL: <https://code.djangoproject.com/ticket/18419#comment:15>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/088.2d858753a701b71aa568b3dadfe5974a%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
