#21445: SelectFilter2.js: quickElement() is missing third argument
-------------------------------------+-------------------------------------
Reporter: parsch.inc@… | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.6
Component: Uncategorized | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by bmispelon):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Hi,
While the proposed PR doesn't look like it would hurt, I can't really
merge it until I can confirm that it does fix some issue and
unfortunately, I can't reproduce the problem locally.
On top of that, two other things bother me:
* The code of `quickElement` looks like it'd prevent the issue you're
describing.
* There are other usage of `quickElement(foo, bar)` in Django's code. If
there's indeed a bug, it should be fixed everywhere.
If you could provide a way to reproduce the issue (a testcase would be
ideal), it would go a long way towards closing this ticket.
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/21445#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/078.143178c4a800545030d4ca92bcc4bb35%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
