#21555: ValidationError is not picklable
-------------------------------+------------------------------------
     Reporter:  zanuxzan       |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  Uncategorized  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------
Changes (by loic84):

 * cc: loic@… (added)
 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 It's a good idea as PY2 can't pickle naive exceptions see:
 http://bugs.python.org/issue1692335 (fix was backported all the way to
 python 3.2).

 Since we'd now be calling the constructor, I think it's good practice to
 pass all arguments so the `args` attribute holds meaningful information.

 I've completed the test suite to ensure the more complex scenarios like
 nested `ValidationError`, or `Validation` with `error_dict` behave as
 expected.

 PR https://github.com/django/django/pull/2022.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21555#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.2ed64c6e90eb5fa5ba75bbe691fbd7b3%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to