#21592: formset.ordered_forms should try to return ordered forms if is_valid() 
is
false
-------------------------------+-------------------------------------
     Reporter:  nickname123    |                    Owner:  pjrharley
         Type:  Uncategorized  |                   Status:  assigned
    Component:  Forms          |                  Version:  1.6
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  1              |                    UI/UX:  0
-------------------------------+-------------------------------------
Changes (by pjrharley):

 * status:  new => assigned
 * owner:  nobody => pjrharley
 * has_patch:  0 => 1
 * stage:  Unreviewed => Accepted


Comment:

 PR here https://github.com/django/django/pull/2093

 I tried doing the same for deleted forms but it broke a whole load of
 other tests that were expecting an empty list. It would be really easy to
 just fix the tests but it makes me wonder if anyone is relying on that
 behaviour? I'd guess not, so if it is ok to change I'll submit that too.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/21592#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.cd4c76c749178d30c1ad27a314e8e842%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to