#21959: widthratio templatetag fails to handle NaN ratio
---------------------------------+--------------------------------------
Reporter: rmoe | Owner:
Type: Bug | Status: new
Component: Template system | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by rmoe):
You just need to call widthratio with float('inf') as both the value and
max_value. like so:
{{{
{% widthratio 'inf' 'inf' 100 %}
}}}
Which will raise this (because ratio is NaN and can't be converted to an
integer):
{{{
ValueError at /project/
cannot convert float NaN to integer
Request Method: GET
Django Version: 1.5.4
Exception Type: ValueError
Exception Value: cannot convert float NaN to integer
Exception Location: /usr/lib/python2.7/dist-
packages/django/template/defaulttags.py in render, line 467
}}}
For some additional context, this was encountered in the Horizon component
of the OpenStack project.
https://github.com/openstack/horizon/blob/master/horizon/templates/horizon/common/_limit_summary.html#L6
When disabling quotas in the Nova component (the data it's trying to build
the pie charts for) all quota values are set to -1 which equates to an
infinite quota. So in the case where quotas are disabled
usage.limits.totalInstancesUsed and usage.limits.maxTotalInstances are
both float('inf'). This breaks the project overview page because of the
exception raised from the widthratio templatetag.
--
Ticket URL: <https://code.djangoproject.com/ticket/21959#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.2868368f4d86922e9d30a13707cb5738%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.
