#21293: Some authentication-related templates are broken
---------------------------------+------------------------------------
Reporter: EvilDMP | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: master
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+------------------------------------
Changes (by ramiro):
* status: closed => new
* resolution: fixed =>
Comment:
Replying to [ticket:21293 EvilDMP]:
> Commit a962286b74f1e8c8cb19fb45a057800da8c2fb56
https://github.com/django/django/commit/a962286b74f1e8c8cb19fb45a057800da8c2fb56
breaks the default template for /user/password/reset/,
Are you sure this happened actually is for the password reset view (the
one in which the user enters his email address so a token is sent there)?
AFAIK there is no access to that particular view from the admin app and
the two password related pages there are
a) the one in which a staff user can set his new password by entering the
old one (i.e. `/admin/password_change/`) and
b) the one in which a superuser can force a new password on any user (i.e.
`/admin/auth/user/<pk>/password/`).
Yes, the naming is a bit confusing :)
I observed the problem reported by this ticket only in case b.
> and possibly others.
Was this actually a problem for any other view?
Replying to [comment:2 EvilDMP]:
> I am not sure how to resolve this, since probably we should not be
showing "Django administration" text on non-admin authentication pages.
In case b there is no danger of this because it's fully handled in the
admin realm in
`django/contrib/auth/admin.py:userAdmin.user_change_password()`
Replying to [comment:8 Tim Graham <timograham@…>]:
> Fixed #21293 -- Adjusted admin header CSS to fix admin password reset
template.
>
> By removing the absolute positioning of the usertools div and using
> float positioning, the #header div will expand based on the height of
> its content.
With this change the height of the header is fixed but, when compared to
1.6, the "Django administration" title text usually located on the left is
still missing.
For that, I've opened https://github.com/django/django/pull/2418 that
updates the context passed to the template in the same spirit of
9c6b57f709bb6123d8abae6ba05e92085ec2f426.
--
Ticket URL: <https://code.djangoproject.com/ticket/21293#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.e745263924fba35bb5afdf2fb612edbe%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
